JamieMason / shrinkpack

Fast, resilient, reproducible builds with npm install.
https://www.npmjs.com/package/shrinkpack
MIT License
793 stars 38 forks source link

Specify minimum supported npm version in readme #59

Closed DrewML closed 8 years ago

DrewML commented 8 years ago

Thank you for the excellent tool! Min version found in this comment

lime commented 8 years ago

Shrinkpack does actually support a lot of earlier versions of npm. I'm using it successfully with npm 2.15.4.

I assume that the comment refers to issue #45, where a change in npm broke compatibility with shrinkpack. Based on discussion in that issue, the problem appeared in npm 3.8.8 and was fixed in 3.10.4.

The supported versions are listed in package.json under engines. I'm not sure if the user will see a warning when using an incompatible version, though.

JamieMason commented 8 years ago

Thanks a lot @DrewML, I won't merge this as-is as I'd like to improve the docs generally, but I will include a mention of that regression in the Docs because you're right.