Closed DrewML closed 8 years ago
Thanks so much @DrewML, running this now.
Great work @DrewML, being able to run all kinds of node/npm combinations on Travis will be a huge help.
I've gone through and made a TODO list, but they're basically either just things I agree about or minor points about the coding style I like to keep in this project;
I'm free at the moment so am happy to pick this up. Thanks a lot,
Jamie
I'm free at the moment so am happy to pick this up. Thanks a lot,
Totally up to you. If not, I can clean all these up tonight.
I just pushed up your work with the above changes applied to it, to https://github.com/JamieMason/shrinkpack/commits/DrewML-travis-tests. Please let me know of anything you'd like to add or change, and thanks again for this big improvement to the project.
@JamieMason Nice! Changes look good to me
Released in 0.16.1 🎆
It works! Currently have it testing against
npm
versions3.8.7
and3.10.5
in node5
and6
, but we can easily update.travis.yml
to add more at any time.Work done:
runtests.sh
to test cases intest.js
ava
for testingnode
andnpm
Opinionated Changes (might be worth discussing):
sinopia
setup, but I ended up stopping because I'm questioning how much value it provides. Based on this PR, it seems like this was added to reduce the dependency onnpm
. But, unless I'm mistaken,sinopia
is still going to be proxying out tonpm
for dependencies, unless they're stored in the repo and linked tosinopia
's storage. (If we do decide to dropsinopia
, I have some commented out code I'll need to remove).test
folder totesting
. This was purely to get around some conflicts withava
's automatic discovery of test files that match a certain pattern. Renaming the directory seemed like the path of least resistance, but we can also override the patternava
uses to discover test files, if you prefer.execa
package to make life a bit easier when working withchild_process
and promises.testutil.js
could also be shell scripts, but my thought process was, if done this way (cross-platform utils), we might be able to get testing setup on Windows usingAppveyor
at some point if it was desired.I'm open to any feedback you have to offer :). If you do decide to accept the PR, I'll need to update
CONTRIBUTING.md
with updated instructions for testing locally.