search

JamieMason / shrinkpack

Fast, resilient, reproducible builds with npm install.
https://www.npmjs.com/package/shrinkpack
MIT License
793 stars 38 forks source link

Use shorter bugs and repository properties #77

Closed zlatanvasovic closed 8 years ago

zlatanvasovic commented 8 years ago

Reference: https://docs.npmjs.com/files/package.json

valscion commented 8 years ago

I wonder what was the reason why you think this is a good change? I don't have any strong opinions about this myself, just wondering what improvements do you feel this brings?

zlatanvasovic commented 8 years ago

You have to understand that software development always requires changes. Every programmer tends to write something in a shorter, but more understandable way if that's possible. It's as simple as that.

There is no reason to keep something written in a incomprehensible, complicated way if the shorter and more understandable way is available.

valscion commented 8 years ago

I'm sorry if I came across rude, I was just interested in hearing your point why you wanted to send this PR. If I understood correctly, your proposition is that this makes the package.json "shorter and more understandable" — which I think is a good thing! :+1:

zlatanvasovic commented 8 years ago

@valscion It wasn't rude, don't worry. It's cool to discuss. :smile:

JamieMason commented 8 years ago

Works for me, happy to merge next time I pick up the project. Thanks a lot for contributing.

JamieMason commented 8 years ago

Merged into master 👍