search

JamieMason / syncpack

Consistent dependency versions in large JavaScript Monorepos.
https://jamiemason.github.io/syncpack/
MIT License
1.34k stars 44 forks source link

fix(workspace): add support for workspace:^ #182

Closed belgattitude closed 6 months ago

belgattitude commented 6 months ago

First of all thanks for your work :)

Description

Tried an upgrade from v11 latest to v12.0.1 and there's an error regarding workspace:^

See https://github.com/belgattitude/httpx/pull/819

yarn install
yarn syncpack lint-semver-ranges --types prod,dev --source "package.json" --source "packages/*/package.json"

Will print

✘ name @httpx/exception or version workspace:^ are not supported packages/json-api/package.json > dependencies [UnsupportedMismatch]
JamieMason commented 6 months ago

Thanks @belgattitude, will take a look. I don't know if this is a regression though as workspace:^ has not been knowingly supported before - how did this behave for you prior to V12?

belgattitude commented 6 months ago

Probably working before or the exit code wasn’t informing an error. At least you’ll see the ci failing after the upgrade. Passed before

JamieMason commented 6 months ago

Released in 12.1.0.

👋 If anyone reading this finds syncpack useful, please tell people about it.

belgattitude commented 6 months ago

Thanks a lot, just tested and it seems to work. Great job and happy new year !