Open jckw opened 2 months ago
Agh, thanks @jckw – that is not good! 😅
As you mentioned, I'd stay on 12.3.0 for now. Something in https://github.com/JamieMason/syncpack/commit/a1c727049b4ce31e7d6a37b683764b5fe32165d6 must have caused this.
update
and prompt
are the only commands without tests, so these kinds of mistakes happen.
I've reverted that commit in 12.3.2
, I'll leave this issue open for looking at the original problem.
I have the same issue using the latest version 12.3.2
For now, the solution is to revert to the 12.3.0 version
@yacosta738 that issue with pnpm install
doesn't seem to be related, please could you explain? When I npm search @lyra/utilities
it is true that it does not exist:
$ npm search @lyra/utilities
NAME | DESCRIPTION | AUTHOR | DATE | VERSION | KEYWORDS
@lyra/preview | Utilities for… | =wsulibs… | 2019-03-22 | 0.3.0 | vega vegapublish realtime content open access publishing preview
@lyra/util | Utilities shared… | =wsulibs… | 2019-03-22 | 0.3.0 | vega vegapublish realtime content open access publishing util
Sorry for the delay. Yes you are right the issue was with version 9 of pnpm
It was solved by adding link-workspace-packages=true
in the .npmrc
we don't use pnpm at all and are seeing this issue on 12.3.2. and 12.3.0.
running prompt where multiple dependencies need to be updated is the issue.
prompt suggests the correct versions, I selected them:
but then this is what writes to my package.jsons:
if I go one by one, and filter prompt to one package at a time (npx syncpack prompt --filter "one-package-at-a-time"
), it updates correctly.
syncpack.rc
Thanks a lot for all this detail @RachelScodes, that matches and confirms what we've been seeing. As I mentioned, the update
command is new and currently quite buggy. Every other command has lots of tests and good confidence they are working, but update
and prompt
do not.
In the meantime I would wait before using this command. A rewrite of syncpack is coming in the next month or so and the situation should improve then.
Description
When using syncpack 12.3.1, running
yarn syncpack update
results in every package being given the version number of the last checked package.e.g.
if
some-package
has a new version1.2.3
, andother-package
has no update and the original package.json looks like:then running
yarn syncpack update
will result in the package.json getting updated to:Example screenshot here where all packages (in all package.jsons in a monorepo) are set to "0.20.17":
I originally thought this might be cache related, but nuking everything doesn't help.
Suggested Solution
Using syncpack 12.3.0 does not have this issue, suggesting the bug was introduced in the latest release.
Help Needed