JamieMason / syncpack

Consistent dependency versions in large JavaScript Monorepos.
https://jamiemason.github.io/syncpack/
MIT License
1.34k stars 44 forks source link

fix: use types export in package.json #218

Closed maksnester closed 2 weeks ago

maksnester commented 1 month ago

This is to provide TS based autocomplete for config fields when type is used like this

/** @type {import("syncpack").RcFile} */
const config = {
  sortFirst: ['name', 'description', 'version', 'scripts'],
};

Without this PR RcFile type can not be resolved.

JamieMason commented 1 month ago

Nice find, thanks Maksim 👍

joshmeads commented 2 weeks ago

Any chance we can get this merged? Currently the example config in the docs includes:

/** @type {import("syncpack").RcFile} */

This doesn't work without this change and leads users to assume something is wrong on their end.

Thanks guys!

JamieMason commented 2 weeks ago

thanks @maksnester, @joshmeads – please give https://github.com/JamieMason/syncpack/releases/tag/12.3.3 a try.