search

JamitLabs / Jetworking

A multi-module library providing a user-friendly interface for common networking tasks
https://JamitLabs.github.io/Jetworking/
MIT License
4 stars 3 forks source link

Client is leaking private API #68

Open mrylmz opened 3 years ago

mrylmz commented 3 years ago

The Client is leaking its private URLSession out in the initializer public init(configuration: Configuration, sessionConfiguration: ((inout URLSession) -> Void)? = nil) but stores it as a private member. Consider making the session public or remove the configurability from the initializer.

JensK611 commented 3 years ago

We need the possibility to configure the URLSession - The member visibility can be changed to be public get this should solve the issue.