search

Jamminroot / intag

Assign tags to files and folders in explorer: much wanted and missed feature of MS Windows Explorer
MIT License
80 stars 7 forks source link

A number of fixes and improvements #20

Closed montoner0 closed 1 year ago

montoner0 commented 1 year ago

19

Jamminroot commented 1 year ago

Sorry for a delay, want to run through the code and check the built artifact first

Jamminroot commented 1 year ago

It's all great, except for the UACHelper - I don't really like the concept of using nugets in this specific app, as I try to keep it a single artifact, without DLLs - especially since its for really rare occasions (install, uninstall). This is why I ripped some of the code and made it "embedded" to sources.

Can you either remove it, or embed relevant parts? Similar to what I did with PropVar, PropertyKey and others.

montoner0 commented 1 year ago

Can you either remove it, or embed relevant parts? Similar to what I did with PropVar, PropertyKey and others.

I've looked at the UACHelper project, it'll be needed to rip the whole project to make it work. I don't think it would be wise. And I personally don't like to reinvent the wheel and copy-paste code from packages. However I see your point and will remove UACHelper from the code.

BTW regarding single-file idea, have you thought about moving to .NET Core? It has a single-file publishing feature.

Jamminroot commented 1 year ago

That's a good point to consider. I'll merge request as is, and will probs migrate to newer dotnet and go for single-file deployment by the weekend.

Again, thanks for you contribution, that's really appreciated 👍