Jammy2211 / PyAutoGalaxy

PyAutoGalaxy: Open-Source Multiwavelength Galaxy Structure & Morphology
https://pyautogalaxy.readthedocs.io/
MIT License
27 stars 13 forks source link

Unified physical NFW profiles #126

Open jhod0 opened 10 months ago

jhod0 commented 10 months ago

Work in progress not ready to merge - but opening this PR for discussion. This is my attempt to make a "unified" interface for converting physical NFW parameters to AutoLens's parameterization (kappa_s, scale_radius), using Colossus to do all the conversions.

The advantages of this approach are:

I can think of one disadvantage:

jhod0 commented 10 months ago

Probably interests @kassidy-kollmann I know you are doing something similar!

jhod0 commented 10 months ago

I have added the NFWPhysical profile and some tests (which pass on my machine).

It samples log10M and concentration, and allows for an elliptical mass profile. This is dirt-simple since it just passes the ellipticities to the underlying NFW profile.

The key part here is it can take any mass definition known by colossus: vir, 200c, 500m, etc.