Move install_requires from requirements.txt to setup.py

Jammy2211 / PyAutoGalaxy

PyAutoGalaxy: Open-Source Multiwavelength Galaxy Structure & Morphology

https://pyautogalaxy.readthedocs.io/

MIT License

28 stars 14 forks source link

Move install_requires from requirements.txt to setup.py #47

Open pllim opened 2 years ago

pllim commented 2 years ago

Currently install_requires requirements are buried in a text file. Would be easier to discover if it is just done in setup.py . No reason to have file I/O overhead during setup for those entries.

Bonus: Move all that data from setup.py to setup.cfg for easier to read package info.

https://github.com/astropy/astropy.github.com/pull/491#issuecomment-1215349065

Jammy2211 commented 1 year ago

We are going to adopt this: https://github.com/Jammy2211/PyAutoGalaxy/issues/67

Would listing all requirements and optional requirements in the pyproject.toml file satisfy this issue?

pllim commented 1 year ago

Yes, since I posted this, using pyproject.toml instead of setup.cfg is now popular. As long as you don't mind pinning to a much newer version of setuptools, I think that is the way to go now.