search

Jammy2211 / PyAutoGalaxy

PyAutoGalaxy: Open-Source Multiwavelength Galaxy Structure & Morphology
https://pyautogalaxy.readthedocs.io/
MIT License
27 stars 13 forks source link

install_requires incomplete? #51

Open pllim opened 2 years ago

pllim commented 2 years ago

I see that in your CI workflow, you install a few more things than what is declared in your setup.py. Are they really needed? If so, they should be declared as install_requires or as optional dependencies in setup.py. Also see #47

https://github.com/Jammy2211/PyAutoGalaxy/blob/449d5a11c70439010a27d7ceffe20d4c6af13c48/.github/workflows/main.yml#L12-L26

https://github.com/Jammy2211/PyAutoGalaxy/blob/449d5a11c70439010a27d7ceffe20d4c6af13c48/.github/workflows/main.yml#L71-L75

https://github.com/astropy/astropy.github.com/pull/491#issuecomment-1215349065

pllim commented 2 years ago

Ah, also I found this documentation that suggests setup.py declarations are indeed incomplete: https://pyautogalaxy.readthedocs.io/en/latest/installation/overview.html#dependencies and https://pyautogalaxy.readthedocs.io/en/latest/installation/source.html#building-from-source