Jammy2211 / PyAutoGalaxy

PyAutoGalaxy: Open-Source Multiwavelength Galaxy Structure & Morphology
https://pyautogalaxy.readthedocs.io/
MIT License
28 stars 14 forks source link

TST: Test against dev version of astropy (and other important upstream dependencies) #68

Open pllim opened 2 years ago

pllim commented 2 years ago

As far as I can tell, the CI is only pulling this for astropy:

https://github.com/Jammy2211/PyAutoGalaxy/blob/449d5a11c70439010a27d7ceffe20d4c6af13c48/requirements.txt#L2

Which means you are only testing against the latest astropy release. Adding a test suite to test against development version of astropy would future-proof your code and prevent surprise on your end when new version of astropy is released.

If testing against dev is too much for you, at least test against pre-release (i.e., release candidate) when it is available (e.g., pip install astropy -U --pre).

Bonus: Also test against oldest version of important dependencies that you claim you support. For instance, I have doubt that your code really works for astropy 3.0 as you claim in your requirements file.

https://github.com/astropy/astropy.github.com/pull/491#issuecomment-1215349065