search

Jamy-L / Handheld-Multi-Frame-Super-Resolution

Handheld Multi-image Super-resolution [Wronski et al., SIGGRAPH19]. Non-official GPU-supported Python implementation.
MIT License
127 stars 20 forks source link

invalid key error when including k_detail as argument #32

Closed heidenrei closed 11 months ago

heidenrei commented 11 months ago

params['merging']['tuning'] was getting accessed before initialization leading to a an invalid key error. I moved the code block that initializes this dictionary above where it was getting accessed. Note that it was only getting accesed iff k_detail and/or k_denoise where included as arguments to run_handheld.py.

Jamy-L commented 11 months ago

Thank you for pushing the fix, this was indeed a bug!

heidenrei commented 11 months ago

No problem. Happy to help.

Jamy Lafenetre @.***>于2023年12月10日 周日19:54写道：

Thank you for pushing the fix, this was indeed a bug!

— Reply to this email directly, view it on GitHub https://github.com/Jamy-L/Handheld-Multi-Frame-Super-Resolution/pull/32#issuecomment-1848943283, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALTS3X53N52UO6JVAL3GSLLYIWPHZAVCNFSM6AAAAABAOM5DP2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBYHE2DGMRYGM . You are receiving this because you authored the thread.Message ID: @.*** com>