search

JamyGolden / PlusSlider

A very agnostic jQuery content slider/fader
http://css-plus.com/examples/plugins/PlusSlider/
MIT License
30 stars 12 forks source link

Possible to clean up non-js css for infiniteSlide? #14

Closed jordanlev closed 11 years ago

jordanlev commented 12 years ago

Hi Jamy, You added this line to the CSS files for the infiniteSlide functionality in v1.4.6:

.plusslider-container .child { display: block; }

...can that be added with javascript by the plugin itself? (I mean, can the javascript set the "display:block" style on all .child elements during PlusSlider initialization?). Since it's not something that has any effect if the slider js never triggers (because there are no .child elements until the slider adds that "child" class upon initialization), seems like it doesn't need to be in the css file itself.

JamyGolden commented 11 years ago

Yeah I think this is a good idea. I've always preferred to keep the CSS out of the JS, but it's definitely unnecessary CSS bloat to keep an absolutely necessary property lying around to be altered in the CSS.

jordanlev commented 11 years ago

Note that I addressed this in by big "Tutorial" pull request.

jordanlev commented 11 years ago

closing this issue because it has already been merged into the codebase.