search

JanDeDobbeleer / homebrew-oh-my-posh

Homebrew formula for Oh my Posh
14 stars 9 forks source link

Path of `themes` directory should be consistent with that in documentation #8

Closed lewis-yeung closed 2 years ago

lewis-yeung commented 2 years ago

In Formula template:

https://github.com/JanDeDobbeleer/homebrew-oh-my-posh/blob/acf2821c53be7c5fd322fe420edadf87857a1c59/build/oh-my-posh.txt#L24

The path of themes directory should be consistent with that in the documentation:

If you want to use a standard theme, you can find them in $(brew --prefix)/oh-my-posh/themes, referencing them as such will always keep them compatible when updating Oh My Posh.

JanDeDobbeleer commented 2 years ago

@lewis-yeung the docs should be updated. I thought I fixed that already, but guess not.

lewis-yeung commented 2 years ago

@JanDeDobbeleer So should it be changed to $(brew --prefix oh-my-posh)/themes in the documentation?

JanDeDobbeleer commented 2 years ago

@lewis-yeung someone did it change it to what it is now because it didn't work otherwise. So we need to double check.

lewis-yeung commented 2 years ago

@JanDeDobbeleer In the documentation of Homebrew:

--prefix [--unbrewed] [--installed] [formula ...]

Display Homebrew's install path. Default:

  • macOS Intel: /usr/local
  • macOS ARM: /opt/homebrew
  • Linux: /home/linuxbrew/.linuxbrew

If formula is provided, display the location where formula is or would be installed.

The original $(brew --prefix oh-my-posh)/themes is correct in principle since mv "themes", prefix works with a non-platform-specific prefix path. This commit might have an excessive modification on it.