JanDeDobbeleer
commented
3 years ago
- oh-my-posh doesn't take into account the extra characters that are added by some symbols in nerd fonts
Yes, that seems to be really hard to do. There's one function that calculates the length, maybe if you could give one that doesn't work, I can create a proper test for it. I did try this already a lot in the past, which is why the horizontal offset property was created on a segment as a workaround.
About Spotify, indeed on Windows it's impossible to get all the context. On MacOS we can query the status from the player, this is impossible on Windows.
Skaytacium
github-actions[bot]
Prerequisites
CONTRIBUTINGguideDescription
Trying to horizontally offset any block, be it right or left aligned, vertically offset (which works) or not, doesn't work for me. I don't know if everyone can reproduce this though.
Old
So I wanted to make my own theme and got pretty far, but there were 2 problems that I encountered: 1. #### Blocks overflowing to the next line So when I added the battery_icon in the battery segment, the leading diamond of this segment would cut out and be invisible until I zoomed out really far.   The way I fixed this is by removing the percentage sign, which worked and didn't overflow. I encountered the same issue for the Spotify segment, where it would overflow if I didn't use the default play/pause/stopped icons. This time, if I added a custom prefix, not only would it just cut out, but it would overflow to the next line, which impacted where I positioned my cursor. This leads us to issue 2. 2. #### Spotify detection oh-my-posh doesn't seem to be able to detect if Spotify has been paused or stopped on the non-windows store version. This makes the paused/stopped icons useless. I have not tried the windows store version as thoroughly as I have used the non-store one, so I will try that soon and see if anything changes.Environment
Steps to Reproduce
Old
1. Get my theme 2. Set prompt to use that theme 3. Play a song on Spotify 4. The last character on the Spotify block will overflow to the next line and paused/stopped won't work (on non-store)Things I tried
Expected behavior: Blocks should offset properly depending on the value given
Actual behavior: They don't
Note: Other than that your prompt theming engine is no less than epic!
Edits
Working Theme
Theme
```json { "console_title": true, "final_space": true, "blocks": [{ "type": "prompt", "alignment": "left", "segments": [{ "type": "os", "style": "diamond", "leading_diamond": "\ue0b2", "foreground": "#42B8B8", "background": "#696969", "properties": { "prefix": "<#F1891B>\ue0b3 ", "windows": "\uf17a" } }, { "type": "shell", "style": "plain", "foreground": "#42B8B8", "background": "#696969", "prefix": "|", "properties": { "prefix": "<#F1891B>\ue621 \uFCB5 " } }, { "type": "root", "style": "plain", "foreground": "#42B8B8", "background": "#696969", "properties": { "prefix": "<#F1891B>\ue621 ", "root_icon": "\ue315" } }, { "type": "path", "style": "plain", "foreground": "#42B8B8", "background": "#696969", "properties": { "prefix": "<#F1891B>\ue621 \ue5fe ", "style": "short" } }, { "type": "exit", "style": "plain", "foreground": "#42B8B8", "background": "#696969", "properties": { "prefix": "<#F1891B>\ue621 ", "always_enabled": true } }, { "type": "executiontime", "style": "diamond", "trailing_diamond": "\ue0b0", "foreground": "#42B8B8", "background": "#696969", "properties": { "prefix": "<#F1891B>\ue621 ", "threshold": 0, "always_enabled": true, "postfix": " <#F1891B>\ue0b1" } } ] }, { "type": "prompt", "alignment": "right", "segments": [{ "type": "session", "style": "diamond", "leading_diamond": "\ue0b2", "foreground": "#42B8B8", "background": "#696969", "properties": { "user_info_separator": " on ", "prefix": "<#F1891B>\ue0b3 " } }, { "type": "time", "style": "plain", "foreground": "#42B8B8", "background": "#696969", "properties": { "prefix": "<#F1891B>\ue621 ", "time_format": "Mon Jan 2 15:04:05 MST 2006" } }, { "type": "battery", "style": "diamond", "trailing_diamond": "\ue0b0", "foreground": "#42B8B8", "background": "#696969", "properties": { "prefix": "<#F1891B>\ue621 ", "display_error": true, "charging_icon": "\uf587 ", "discharging_icon": "\uf57d ", "charged_icon": "\uf578 ", "display_charging": true, "postfix": " <#F1891B>\ue0b1" } } ] }, { "type": "newline" }, { "type": "prompt", "alignment": "left", "segments": [{ "type": "git", "style": "diamond", "trailing_diamond": "\ue0b0", "leading_diamond": "\ue0b2", "foreground": "#42B8B8", "background": "#696969", "properties": { "prefix": "<#F1891B>\ue0b3 ", "postfix": " <#F1891B>\ue0b1", "branch_icon": "\ufb2b ", "display_stash_count": true, "status_separator_icon": " <#F1891B>\ue621 ", "local_working_icon": " \uf8ea", "local_staged_icon": " \uf62b", "stash_count_icon": "<#F1891B>\ue621 \uf15b ", "tag_icon": "\uf02b", "merge_icon": "\ufb2c", "display_upstream_icon": true, "github_icon": "\uf408 ", "git_icon": "\uf7a1 " } }] }, { "type": "prompt", "alignment": "right", "segments": [{ "type": "spotify", "style": "diamond", "trailing_diamond": "\ue0b0", "leading_diamond": "\ue0b2", "foreground": "#42B8B8", "background": "#696969", "properties": { "playing_icon": "\uf90c ", "paused_icon": "\uf8e5 ", "stopped_icon": "\ufb66 ", "track_separator": " <#F1891B>\ue621 ", "prefix": "<#F1891B>\ue0b3 \uf1bc ", "postfix": " <#F1891B>\ue0b1" } }] }, { "type": "newline" }, { "type": "prompt", "alignment": "left", "segments": [{ "type": "text", "style": "diamond", "trailing_diamond": "\ue0b0", "leading_diamond": "\ue0b2", "foreground": "#42B8B8", "background": "#696969", "properties": { "text": "sk", "prefix": "<#F1891B>\ue0b3", "postfix": "<#F1891B>\ue0b1" } }] } ] } ```