JanDeDobbeleer / oh-my-posh

The most customisable and low-latency cross platform/shell prompt renderer
https://ohmyposh.dev
MIT License
17.02k stars 2.37k forks source link

Fish $( ... ) is not supported #2692

Closed ehawman closed 2 years ago

ehawman commented 2 years ago

Code of Conduct

What happened?

Had OMP installed on an RPI. Config got borked so I wiped it. Now Fish is crying that oh-my-posh init fish doesn't conform.

image

- (line 59): $(...) is not supported. In fish, please use '(string)'.
if test "$(string match -e '_render_transient' $(bind \r --user 2>/dev/null))" != ''
         ^
from sourcing file -
source: Error while reading file “<stdin>”

Installed via

sudo wget https://github.com/JanDeDobbeleer/oh-my-posh/releases/latest/download/posh-linux-arm -O /usr/local/bin/oh-my-posh
sudo chmod +x /usr/local/bin/oh-my-posh

I'm very confused since this was working before. Also Bash can run it just fine.

Output of oh-my-posh init fish ``` set --export POSH_THEME /home/abcdefg/.cache/oh-my-posh/config.omp.json set --global POWERLINE_COMMAND "oh-my-posh" set --global CONDA_PROMPT_MODIFIER false set --global omp_tooltip_command "" set --global omp_transient 0 function fish_prompt set --local omp_status_cache_temp $status # clear from cursor to end of screen as # commandline --function repaint does not do this # see https://github.com/fish-shell/fish-shell/issues/8418 printf \e\[0J if test "$omp_transient" = "1" /usr/local/bin/oh-my-posh print transient --config $POSH_THEME --shell fish --error $omp_status_cache --execution-time $omp_duration --stack-count $omp_stack_count --shell-version $FISH_VERSION return end set --global omp_status_cache $omp_status_cache_temp set --global omp_stack_count (count $dirstack) set --global omp_duration "$CMD_DURATION$cmd_duration" # check if variable set, < 3.2 case if set --query omp_lastcommand; and test "$omp_lastcommand" = "" set omp_duration 0 end # works with fish >=3.2 if set --query omp_last_status_generation; and test "$omp_last_status_generation" = "$status_generation" set omp_duration 0 end if set --query status_generation set --global --export omp_last_status_generation $status_generation end /usr/local/bin/oh-my-posh print primary --config $POSH_THEME --shell fish --error $omp_status_cache --execution-time $omp_duration --stack-count $omp_stack_count --shell-version $FISH_VERSION end function fish_right_prompt if test "$omp_transient" = "1" echo -n "" set omp_transient 0 return end if test -n "$omp_tooltip_command" set omp_tooltip_prompt (/usr/local/bin/oh-my-posh print tooltip --config $POSH_THEME --shell fish --error $omp_status_cache --shell-version $FISH_VERSION --command $omp_tooltip_command) if test -n "$omp_tooltip_prompt" echo -n $omp_tooltip_prompt set omp_tooltip_command "" return end end /usr/local/bin/oh-my-posh print right --config $POSH_THEME --shell fish --error $omp_status_cache --execution-time $omp_duration --stack-count $omp_stack_count --shell-version $FISH_VERSION end function postexec_omp --on-event fish_postexec # works with fish <3.2 # pre and postexec not fired for empty command in fish >=3.2 set --global --export omp_lastcommand $argv end # perform cleanup so a new initialization in current session works if test "$(string match -e '_render_transient' $(bind \r --user 2>/dev/null))" != '' bind -e \r end if test "$(string match -e '_render_tooltip' $(bind \x20 --user 2>/dev/null))" != '' bind -e \x20 end # tooltip function _render_tooltip commandline --function expand-abbr set omp_tooltip_command (commandline --current-buffer | string collect) commandline --insert " " commandline --function repaint end if test "true" = "true" bind \x20 _render_tooltip end # transient prompt function _render_transient set omp_transient 1 commandline --function repaint commandline --function execute end if test "true" = "true" bind \r _render_transient end # legacy functions function enable_poshtooltips end function enable_poshtransientprompt end ```

Theme

oh-my-posh init fish | source

What OS are you seeing the problem on?

Linux

Which shell are you using?

fish

Log output

<details>
 <summary>Logs</summary>

Version: 8.33.0

Segments:

ConsoleTitle(true) -   7 ms - fish in ~
session(true)  -   4 ms -   abcdefg 
path(true)     -   5 ms -   ~
git(false)     -   1 ms -
root(false)    -   0 ms -
exit(true)     -   6 ms -   
node(false)    -   0 ms -
go(false)      -   0 ms -
python(false)  -   2 ms -
shell(true)    -   4 ms - in fish
time(true)     -   3 ms - at 14:05:28

Run duration: 354.235147ms

Cache path: /home/abcdefg/.cache/oh-my-posh

Config path: /home/abcdefg/.cache/oh-my-posh/config.omp.json

Logs:

2022/08/22 14:05:28 debug: Getenv

2022/08/22 14:05:28 Getenv duration: 142.916µs, args: XDG_CACHE_HOME
2022/08/22 14:05:28 CachePath duration: 412.812µs, args:
2022/08/22 14:05:28 debug: Getenv

2022/08/22 14:05:28 Getenv duration: 102.969µs, args: POSH_THEME
2022/08/22 14:05:28 debug: Getenv

2022/08/22 14:05:28 Getenv duration: 42.031µs, args: XDG_CACHE_HOME
2022/08/22 14:05:28 CachePath duration: 356.249µs, args:
2022/08/22 14:05:28 debug: HTTPRequest
GET /JanDeDobbeleer/oh-my-posh/v8.33.0/themes/default.omp.json HTTP/1.1
Host: raw.githubusercontent.com
User-Agent: Go-http-client/1.1
Accept-Encoding: gzip

2022/08/22 14:05:28 debug: HTTPRequest
{
  "$schema": "https://raw.githubusercontent.com/JanDeDobbeleer/oh-my-posh/main/themes/schema.json",
  "blocks": [
    {
      "alignment": "left",
      "segments": [
        {
          "background": "p:yellow",
          "foreground": "p:black",
          "leading_diamond": "\ue0b6",
          "properties": {
            "display_host": false
          },
          "style": "diamond",
          "template": " {{ if .SSHSession }}\uf817 {{ end }}{{ .UserName }} ",
          "trailing_diamond": "\ue0b0",
          "type": "session"
        },
        {
          "background": "p:orange",
          "foreground": "p:white",
          "powerline_symbol": "\ue0b0",
          "properties": {
            "home_icon": "~",
            "style": "folder"
          },
          "style": "powerline",
          "template": " \uf74a {{ path .Path .Location }} ",
          "type": "path"
        },
        {
          "background": "p:green",
          "background_templates": [
            "{{ if or (.Working.Changed) (.Staging.Changed) }}p:yellow{{ end }}",
            "{{ if and (gt .Ahead 0) (gt .Behind 0) }}p:red{{ end }}",
            "{{ if gt .Ahead 0 }}#49416D{{ end }}",
            "{{ if gt .Behind 0 }}#7A306C{{ end }}"
          ],
          "foreground": "p:black",
          "foreground_templates": [
            "{{ if or (.Working.Changed) (.Staging.Changed) }}p:black{{ end }}",
            "{{ if and (gt .Ahead 0) (gt .Behind 0) }}p:white{{ end }}",
            "{{ if gt .Ahead 0 }}p:white{{ end }}"
          ],
          "powerline_symbol": "\ue0b0",
          "properties": {
            "branch_max_length": 25,
            "fetch_status": true,
            "fetch_upstream_icon": true,
            "github_icon": "\uf7a3"
          },
          "style": "powerline",
          "template": " {{ if .UpstreamURL }}{{ url .UpstreamIcon .UpstreamURL }} {{ end }}{{ .HEAD }}{{ .BranchStatus }}{{ if .Working.Changed }} \uf044 {{ .Working.String }}{{ end }}{{ if .Staging.Changed }} \uf046 {{ .Staging.String }}{{ end }} ",
          "type": "git"
        },
        {
          "background": "p:yellow",
          "foreground": "p:white",
          "powerline_symbol": "\ue0b0",
          "properties": {
            "root_icon": "\uf0ad"
          },
          "style": "powerline",
          "template": " \uf0e7 ",
          "type": "root"
        },
        {
          "background": "p:blue",
          "background_templates": [
            "{{ if gt .Code 0 }}p:red{{ end }}"
          ],
          "foreground": "p:white",
          "leading_diamond": "<transparent,background>\ue0b0</>",
          "properties": {
            "always_enabled": true
          },
          "style": "diamond",
          "template": " {{ if gt .Code 0 }}\uf00d{{ else }}\uf00c{{ end }} ",
          "trailing_diamond": "\ue0b4",
          "type": "exit"
        }
      ],
      "type": "prompt"
    },
    {
      "segments": [
        {
          "background": "transparent",
          "foreground": "p:green",
          "properties": {
            "display_mode": "files",
            "fetch_package_manager": false,
            "home_enabled": false
          },
          "style": "plain",
          "template": "\uf898 ",
          "type": "node"
        },
        {
          "background": "transparent",
          "foreground": "p:blue",
          "properties": {
            "fetch_version": false
          },
          "style": "powerline",
          "template": "\ufcd1 ",
          "type": "go"
        },
        {
          "background": "transparent",
          "foreground": "p:yellow",
          "properties": {
            "display_mode": "files",
            "fetch_version": true,
            "fetch_virtual_env": false
          },
          "style": "plain",
          "template": "\ue235 ",
          "type": "python"
        },
        {
          "background": "transparent",
          "foreground": "p:white",
          "style": "plain",
          "template": "in <p:blue><b>{{ .Name }}</b></> ",
          "type": "shell"
        },
        {
          "background": "transparent",
          "foreground": "p:white",
          "style": "plain",
          "template": "at <p:blue><b>{{ .CurrentDate | date \"15:04:05\" }}</b></>",
          "type": "time"
        }
      ],
      "type": "rprompt"
    }
  ],
  "console_title_template": "{{ .Shell }} in {{ .Folder }}",
  "final_space": true,
  "palette": {
    "black": "#262B44",
    "blue": "#4B95E9",
    "green": "#59C9A5",
    "orange": "#F07623",
    "red": "#D81E5B",
    "white": "#E0DEF4",
    "yellow": "#F3AE35"
  },
  "secondary_prompt": {
    "background": "transparent",
    "foreground": "p:black",
    "template": "<p:yellow,transparent>\ue0b6</><,p:yellow> > </><p:yellow,transparent>\ue0b0</> "
  },
  "tooltips": [
    {
      "background": "p:orange",
      "foreground": "p:white",
      "leading_diamond": "\ue0b6",
      "properties": {
        "display_default": true
      },
      "style": "diamond",
      "template": " \ue7ad {{ .Profile }}{{ if .Region }}@{{ .Region }}{{ end }} ",
      "tips": [
        "aws"
      ],
      "trailing_diamond": "\ue0b4",
      "type": "aws"
    },
    {
      "background": "p:blue",
      "foreground": "p:white",
      "leading_diamond": "\ue0b6",
      "style": "diamond",
      "template": " \ufd03 {{ .Name }} ",
      "tips": [
        "az"
      ],
      "trailing_diamond": "\ue0b4",
      "type": "az"
    }
  ],
  "transient_prompt": {
    "background": "transparent",
    "foreground": "p:black",
    "template": "<p:yellow,transparent>\ue0b6</><,p:yellow> {{ .Folder }} </><p:yellow,transparent>\ue0b0</> "
  },
  "version": 2
}

2022/08/22 14:05:28 HTTPRequest duration: 297.897222ms, args: https://raw.githubusercontent.com/JanDeDobbeleer/oh-my-posh/v8.33.0/themes/default.omp.json
2022/08/22 14:05:28 downloadConfig duration: 299.640241ms, args: https://raw.githubusercontent.com/JanDeDobbeleer/oh-my-posh/v8.33.0/themes/default.omp.json
2022/08/22 14:05:28 resolveConfigPath duration: 300.172897ms, args:
2022/08/22 14:05:28 Init duration: 303.016124ms, args:
2022/08/22 14:05:28 Flags duration: 1.823µs, args:
2022/08/22 14:05:28 config.loadConfig duration: 13.281396ms, args:
2022/08/22 14:05:28 Flags duration: 1.25µs, args:
2022/08/22 14:05:28 debug: Getenv

2022/08/22 14:05:28 Getenv duration: 37.032µs, args: OMP_CACHE_DISABLED
2022/08/22 14:05:28 Root duration: 5.781µs, args:
2022/08/22 14:05:28 Shell duration: 3.579424ms, args:
2022/08/22 14:05:28 ErrorCode duration: 1.25µs, args:
2022/08/22 14:05:28 debug: Getenv

2022/08/22 14:05:28 Getenv duration: 32.344µs, args: WSL_DISTRO_NAME
2022/08/22 14:05:28 IsWsl duration: 74.844µs, args:
2022/08/22 14:05:28 debug: Pwd
/home/abcdefg
2022/08/22 14:05:28 Pwd duration: 199.792µs, args:
2022/08/22 14:05:28 PathSeparator duration: 1.25µs, args:
2022/08/22 14:05:28 PathSeparator duration: 781ns, args:
2022/08/22 14:05:28 debug: User
abcdefg
2022/08/22 14:05:28 User duration: 26.302µs, args:
2022/08/22 14:05:28 debug: Host
hijklmn
2022/08/22 14:05:28 Host duration: 39.271µs, args:
2022/08/22 14:05:28 GOOS duration: 1.302µs, args:
2022/08/22 14:05:28 TemplateCache duration: 4.476455ms, args:
2022/08/22 14:05:28 Flags duration: 1.302µs, args:
2022/08/22 14:05:28 debug: Pwd
/home/abcdefg
2022/08/22 14:05:28 Pwd duration: 47.239µs, args:
2022/08/22 14:05:28 GOOS duration: 1.042µs, args:
2022/08/22 14:05:28 debug: Getenv
192.168.2.44 51767 192.168.2.205 22
2022/08/22 14:05:28 Getenv duration: 27.24µs, args: SSH_CONNECTION
2022/08/22 14:05:28 TemplateCache duration: 1.042µs, args:
2022/08/22 14:05:28 TemplateCache duration: 2.917µs, args:
2022/08/22 14:05:28 Shell duration: 2.032µs, args:
2022/08/22 14:05:28 debug: Pwd
/home/abcdefg
2022/08/22 14:05:28 Pwd duration: 53.385µs, args:
2022/08/22 14:05:28 GOOS duration: 1.302µs, args:
2022/08/22 14:05:28 debug: Pwd
/home/abcdefg
2022/08/22 14:05:28 Pwd duration: 25.313µs, args:
2022/08/22 14:05:28 Flags duration: 1.042µs, args:
2022/08/22 14:05:28 debug: Pwd
/home/abcdefg
2022/08/22 14:05:28 Pwd duration: 23.073µs, args:
2022/08/22 14:05:28 GOOS duration: 833ns, args:
2022/08/22 14:05:28 GOOS duration: 834ns, args:
2022/08/22 14:05:28 PathSeparator duration: 1.042µs, args:
2022/08/22 14:05:28 PathSeparator duration: 781ns, args:
2022/08/22 14:05:28 PathSeparator duration: 729ns, args:
2022/08/22 14:05:28 PathSeparator duration: 729ns, args:
2022/08/22 14:05:28 GOOS duration: 886ns, args:
2022/08/22 14:05:28 debug: Getenv

2022/08/22 14:05:28 Getenv duration: 26.927µs, args: WSL_DISTRO_NAME
2022/08/22 14:05:28 IsWsl duration: 65.521µs, args:
2022/08/22 14:05:28 StackCount duration: 1.458µs, args:
2022/08/22 14:05:28 DirIsWritable duration: 77.031µs, args:
2022/08/22 14:05:28 TemplateCache duration: 1.771µs, args:
2022/08/22 14:05:28 TemplateCache duration: 3.698µs, args:
2022/08/22 14:05:28 Shell duration: 2.916µs, args:
2022/08/22 14:05:28 debug: Pwd
/home/abcdefg
2022/08/22 14:05:28 Pwd duration: 52.343µs, args:
2022/08/22 14:05:28 GOOS duration: 1.407µs, args:
2022/08/22 14:05:28 debug: Getenv

2022/08/22 14:05:28 Getenv duration: 28.021µs, args: WSL_DISTRO_NAME
2022/08/22 14:05:28 IsWsl duration: 71.406µs, args:
2022/08/22 14:05:28 GOOS duration: 782ns, args:
2022/08/22 14:05:28 debug: CommandPath
/usr/bin/git
2022/08/22 14:05:28 CommandPath duration: 154.74µs, args: git
2022/08/22 14:05:28 HasCommand duration: 196.302µs, args: git
2022/08/22 14:05:28 debug: Pwd
/home/abcdefg
2022/08/22 14:05:28 Pwd duration: 24.583µs, args:
2022/08/22 14:05:28 error: HasParentFilePath
stat /.git: no such file or directory
2022/08/22 14:05:28 HasParentFilePath duration: 151.614µs, args: .git
2022/08/22 14:05:28 debug: Pwd
/home/abcdefg
2022/08/22 14:05:28 Pwd duration: 33.593µs, args:
2022/08/22 14:05:28 GOOS duration: 937ns, args:
2022/08/22 14:05:28 Root duration: 3.125µs, args:
2022/08/22 14:05:28 debug: Pwd
/home/abcdefg
2022/08/22 14:05:28 Pwd duration: 31.354µs, args:
2022/08/22 14:05:28 GOOS duration: 938ns, args:
2022/08/22 14:05:28 ErrorCode duration: 1.562µs, args:
2022/08/22 14:05:28 TemplateCache duration: 1.667µs, args:
2022/08/22 14:05:28 TemplateCache duration: 3.698µs, args:
2022/08/22 14:05:28 Shell duration: 2.395µs, args:
2022/08/22 14:05:28 TemplateCache duration: 2.656µs, args:
2022/08/22 14:05:28 Flags duration: 2.083µs, args:
2022/08/22 14:05:28 debug: Pwd
/home/abcdefg
2022/08/22 14:05:28 Pwd duration: 37.344µs, args:
2022/08/22 14:05:28 GOOS duration: 1.354µs, args:
2022/08/22 14:05:28 debug: Pwd
/home/abcdefg
2022/08/22 14:05:28 Pwd duration: 23.854µs, args:
2022/08/22 14:05:28 debug: Pwd
/home/abcdefg
2022/08/22 14:05:28 Pwd duration: 32.396µs, args:
2022/08/22 14:05:28 GOOS duration: 833ns, args:
2022/08/22 14:05:28 debug: Pwd
/home/abcdefg
2022/08/22 14:05:28 Pwd duration: 97.24µs, args:
2022/08/22 14:05:28 debug: Pwd
/home/abcdefg
2022/08/22 14:05:28 Pwd duration: 37.604µs, args:
2022/08/22 14:05:28 GOOS duration: 833ns, args:
2022/08/22 14:05:28 debug: Pwd
/home/abcdefg
2022/08/22 14:05:28 Pwd duration: 23.802µs, args:
2022/08/22 14:05:28 debug: Pwd
/home/abcdefg
2022/08/22 14:05:28 Pwd duration: 24.063µs, args:
2022/08/22 14:05:28 PathSeparator duration: 1.302µs, args:
2022/08/22 14:05:28 debug: HasFiles
false
2022/08/22 14:05:28 HasFiles duration: 675.52µs, args: *.py
2022/08/22 14:05:28 debug: Pwd
/home/abcdefg
2022/08/22 14:05:28 Pwd duration: 26.25µs, args:
2022/08/22 14:05:28 PathSeparator duration: 834ns, args:
2022/08/22 14:05:28 debug: HasFiles
false
2022/08/22 14:05:28 HasFiles duration: 506.667µs, args: *.ipynb
2022/08/22 14:05:28 debug: Pwd
/home/abcdefg
2022/08/22 14:05:28 Pwd duration: 24.844µs, args:
2022/08/22 14:05:28 PathSeparator duration: 834ns, args:
2022/08/22 14:05:28 debug: HasFiles
false
2022/08/22 14:05:28 HasFiles duration: 198.438µs, args: pyproject.toml
2022/08/22 14:05:28 debug: Pwd
/home/abcdefg
2022/08/22 14:05:28 Pwd duration: 23.49µs, args:
2022/08/22 14:05:28 PathSeparator duration: 834ns, args:
2022/08/22 14:05:28 debug: HasFiles
false
2022/08/22 14:05:28 HasFiles duration: 147.083µs, args: venv.bak
2022/08/22 14:05:28 debug: HasFolder
false
2022/08/22 14:05:28 HasFolder duration: 55.937µs, args: .venv
2022/08/22 14:05:28 debug: HasFolder
false
2022/08/22 14:05:28 HasFolder duration: 73.75µs, args: venv
2022/08/22 14:05:28 debug: HasFolder
false
2022/08/22 14:05:28 HasFolder duration: 55.156µs, args: virtualenv
2022/08/22 14:05:28 debug: HasFolder
false
2022/08/22 14:05:28 HasFolder duration: 57.187µs, args: env
2022/08/22 14:05:28 debug: HasFolder
false
2022/08/22 14:05:28 HasFolder duration: 52.708µs, args: venv-win
2022/08/22 14:05:28 debug: HasFolder
false
2022/08/22 14:05:28 HasFolder duration: 54.323µs, args: pyenv-win
2022/08/22 14:05:28 debug: Pwd
/home/abcdefg
2022/08/22 14:05:28 Pwd duration: 33.802µs, args:
2022/08/22 14:05:28 GOOS duration: 1.25µs, args:
2022/08/22 14:05:28 Shell duration: 1.928µs, args:
2022/08/22 14:05:28 Flags duration: 989ns, args:
2022/08/22 14:05:28 TemplateCache duration: 1.459µs, args:
2022/08/22 14:05:28 TemplateCache duration: 2.76µs, args:
2022/08/22 14:05:28 Shell duration: 1.927µs, args:
2022/08/22 14:05:28 debug: Pwd
/home/abcdefg
2022/08/22 14:05:28 Pwd duration: 45.833µs, args:
2022/08/22 14:05:28 GOOS duration: 1.354µs, args:
2022/08/22 14:05:28 TemplateCache duration: 1.562µs, args:
2022/08/22 14:05:28 TemplateCache duration: 3.229µs, args:
2022/08/22 14:05:28 Shell duration: 2.5µs, args:
2022/08/22 14:05:28 debug: Getenv

2022/08/22 14:05:28 Getenv duration: 43.75µs, args: XDG_CACHE_HOME
2022/08/22 14:05:28 CachePath duration: 221.614µs, args:
2022/08/22 14:05:28 Flags duration: 1.198µs, args:

JanDeDobbeleer commented 2 years ago

@lewis-yeung seems based on your latest changes?

@ehawman are you on the latest fish shell?

lewis-yeung commented 2 years ago

@ehawman It works fine with fish v3.5.1 on my end. What's your fish version?

ehawman commented 2 years ago

@JanDeDobbeleer @lewis-yeung Ah the latest version on apt is 3.1.2-3. I'll try manually installing it from source.

I should note that the docs currently advise using the latest version, but cite 3.1.2 specifically. Might want to update that per these changes.

ehawman commented 2 years ago

My little RPi2 is chuggin, chuggin, chuggin... 🚂

lewis-yeung commented 2 years ago

I have considered using the (...) form instead, but fish will ignore an empty string argument expanded from it. E.g., either test -z (string match 'a' 'b') or test -n (string match 'a' 'b') returns a successful status. 😅

EDITED: A clumsy workaround is using echo: test -z (echo (string match 'a' 'b')). @JanDeDobbeleer @ehawman Do you have a better idea on how to refactor this logic?

JanDeDobbeleer commented 2 years ago

@lewis-yeung if @ehawman can confirm the latest version is compatible, we can add the version requirement. If not, I guess I'd rather revert this for fish than to include a hack?

lewis-yeung commented 2 years ago

@JanDeDobbeleer We don't have to revert. The latest version is compatible. It's described in the docs of fish:

A command substitution can have a dollar sign before the opening parenthesis like outercommand $(innercommand). This variant is also allowed inside double quotes. When using double quotes, the command output is not split up by lines.

JanDeDobbeleer commented 2 years ago

@lewis-yeung let's add that to the docs in this case and have a standard response ready for the inflow of issues 😁

ehawman commented 2 years ago

🚂 ☁️ ☁️ ☁️ ☁️

I think I canpile, I think I canpile

87% y'all. I haven't forgotten you 😄

lewis-yeung commented 2 years ago

Fish supports $(...) and "$(...)" since v3.4.0, as described in its changelog.

ehawman commented 2 years ago

Ok (finally) confirming that 3.5.1 works just fine. :)

Apologies for the confusion, fellas. If it didn't take me an hour I'd build 3.4.0 for y'all too.

Yeah just update the docs and I think you're good. I'd have immediately jumped to that conclusion myself, but I saw 3.1.2 and assumed I was good.

lewis-yeung commented 2 years ago

let's add that to the docs in this case and have a standard response ready for the inflow of issues 😁

@JanDeDobbeleer See #2699.

github-actions[bot] commented 9 months ago

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a discussion first, complete the body with all the details necessary to reproduce, and mention this issue as reference.