language_test / .Mismatch wrong if .nvmrc isn't fully qualified

JanDeDobbeleer / oh-my-posh

The most customisable and low-latency cross platform/shell prompt renderer

https://ohmyposh.dev

MIT License

16.71k stars 2.35k forks source link

language_test / .Mismatch wrong if .nvmrc isn't fully qualified #4009

Closed jonaskuske closed 1 year ago

jonaskuske commented 1 year ago

Code of Conduct

[X] I agree to follow this project's Code of Conduct

What happened?

When .nvmrc contains just 18, .Mismatch should be false for all 18.x Node versions. Currently my prompt is red indicating a version mismatch despite using Node v18.16.0 in a repo that specifies 18 in its .nvmrc

(feels like a bug but could also be framed as a feature request, I guess?)

Theme

What OS are you seeing the problem on?

Windows, Linux

Which shell are you using?

powershell, zsh

Log output

JanDeDobbeleer commented 1 year ago

@jonaskuske this is only true when it specifies a major version, right (so, no dots)?

jonaskuske commented 1 year ago

@JanDeDobbeleer Ah sorry, turns out everything is working in my WSL setup, including just the major as specifier. The issue is that OMP always reports a Mismatch in my Windows/PowerShell setup, even with "18.16.0" in .nvmrc. Will investigate and potentially open another issue.

github-actions[bot] commented 8 months ago

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a discussion first, complete the body with all the details necessary to reproduce, and mention this issue as reference.