JanDeDobbeleer / oh-my-posh

The most customisable and low-latency cross platform/shell prompt renderer
https://ohmyposh.dev
MIT License
17.35k stars 2.38k forks source link

OMP reports inaccurate version #4020

Closed metal-gabe closed 1 year ago

metal-gabe commented 1 year ago

Code of Conduct

What happened?

I'm using the following eval command in my shell to initialize my OMP theme:

eval "$(oh-my-posh init zsh --config "$(brew --cellar)/oh-my-posh/$(oh-my-posh version)/themes/atomicbit.omp.json")"

However, the theme is broken right now because the command oh-my-posh version reports 17.6.0 when the actual version (and directory name) is 17.6.0_1.

Theme

Atomic Bit

What OS are you seeing the problem on?

macOS

Which shell are you using?

zsh

Log output

I just see `CONFIG ERROR` in the Posh theme in my terminal/shell. The shell still works, but the theme doesn't.
JanDeDobbeleer commented 1 year ago

@gflujan that's not a bug but probably the non-official brew which had to do a fix to get the version number right using a revision. We hardly ever do fixes on existing formulae.

metal-gabe commented 1 year ago

@JanDeDobbeleer I wanted to revisit this because it seems like your cask is now having this issue.

I just updated oh-my-posh and the version it updated to is 18.7.0_1, but running oh-my-posh --version reports back 18.7.0. Which breaks my shell paths/commands/args/etc.

I can confirm that I have used your official cask of jandedobbeleer/oh-my-posh/oh-my-posh to install.

JanDeDobbeleer commented 1 year ago

@gflujan the cask version and oh-my-posh version will always be different on revisions. That's not something we can solve. As I stated above, it's rare that this happens though.

github-actions[bot] commented 8 months ago

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a discussion first, complete the body with all the details necessary to reproduce, and mention this issue as reference.