Closed NoahMDMi closed 1 year ago
I'll have a look when I'm back from my holidays. What's interesting is that it's truly gone.
@NoahMDMi I can't reproduce this with the same fish version using your config on macOS. So, I'm assuming this is going to be a terminal issue. The character is actually swallowed, so this would imply there's an ANSI character being printed that clears the line at then end (that's the hack we have for PowerShell as well, maybe fish does this too on Linux for some reason). Either way, it's either a fish, or terminal issue, but we do get the correct line length and place the block correctly, otherwise it would overflow to the next line (which it doesn't).
I'm encountering this same issue in Windows Terminal, ConEmu and Alacritty, so it doesn't seem to be a terminal issue. In Alacritty (top lines are bash, bottom are fish): I'm also using the same theme for PowerShell, where it works fine.
@soxfox42 still a fish issue on Windows in that case as I'm unable to reproduce on macOS. That implies that somehow they do things differently (and incorrect) there.
Yep, looks like you're right. I can reproduce the issue with a custom fish_prompt
. Interestingly, I can also reproduce it in Termux on Android, but not in the terminal emulators I've tried on Linux.
I'll see if there's any reports of this on the fish side. For anyone else facing this problem, here's the fish issue. Looks like it was fixed, then reverted because the fix broke more things.
@soxfox42 we had that logic in oh-my-posh as well and I can confirm that breaks a lot of things. So yeah, challenging.
This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a discussion first, complete the body with all the details necessary to reproduce, and mention this issue as reference.
Code of Conduct
What happened?
I have an existing oh-my-posh theme that I use on Windows, but today I was setting up my WSL terminal to also use that theme, and noticed it was dropping off the last character of the right-aligned prompt (not an rprompt). I am using Windows Terminal.
Additionally, I did some basic testing and found:
path
segment, whichever segment is last loses the last characterrprompt
, which displayed normally with the last character (and was aligned with the above right-aligned prompt)In PowerShell, bash, and zsh, I didn't see this behavior.
FISH:
PWSH:
ZSH:
BASH:
Theme
A theme inspired by bubbles, but with heavy modifications made by myself.
What OS are you seeing the problem on?
Windows, Linux
Which shell are you using?
fish
Log output