Closed matcls closed 1 year ago
Can't confirm this on nushell 0.84.0 (same as yours). Tried OMP 18.5.1 and 18.9.0 (latest atm). Running Linux 6.4.0 and default M365Princess theme.
Thanks @ZerdoX-x are you using a theme with rprompt? It seems to happen only with themes with rprompt
I guess no, M365Princess doesn't use right side of the prompt.
I tried to use your theme and for some reason I can't see right side of the prompt. Do I need to do something special to get ram usage as on your screenshot? I am using the same file which oh-my-posh init nu
gave me and completely default nushell (no settings in config file)
Also, if needed, you can check my configuration: https://git.sr.ht/~zerdox/dotfiles/tree/master/item/home/zerdox/.config/oh-my-posh https://git.sr.ht/~zerdox/dotfiles/tree/master/item/home/zerdox/.config/nushell
UPD: I remember when I was using generated nu config, I had prompt with right part showing time.
@matcls confirmed to be an issue, although I can't explain this. Even when moving the rprompt a bit to the left it keeps adding a newline. I have the feeling this is a nushell thing where going from using ANSI characters to position the right prompt (what we did before) to using spaces (correctly calculated) results in this weird behaviour.
@fdncred or @jntrnr any idea as to why this happens? We don't use nushell's built-in PROMPT_COMMAND_RIGHT
due to it printing the right prompt on the first line which breaks multi-line prompts (if that's changed in the meantime I missed it).
I haven't looked at the details of this issue yet but you mention the right prompt line. Just wondering if you knew there was a config option for which line the right prompt is printed on?
I'm in the car, on my phone, or I'd look it up and tell you what it is.
This is the config.nu setting we added a while back to control where the right prompt is rendered.
render_right_prompt_on_last_line: true # true or false to enable or disable right prompt to be rendered on last line of the prompt.
I'm wondering if this was used if it would make a difference in this issue?
I looked at it for a while and I can't see how to reproduce the problem in nushell without using this config in omp. Not saying it's not a nushell problem, but I'm not seeing a good way to repro it. It could be a reedline issue too, the nushell line editor.
I'm wondering if this was used if it would make a difference in this issue?
@fdncred confirmed to be working. I'm going to make that change and add this information to the docs. Amazing!
This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a discussion first, complete the body with all the details necessary to reproduce, and mention this issue as reference.
Code of Conduct
What happened?
In NuShell (linux and windows) an empty line is printed when running a command Testing it seems to happen only with themes with rprompt
This happens since version v18.2.3
Does not occur in powershell or fish.
Theme
What OS are you seeing the problem on?
Windows, Linux
Which shell are you using?
nu
Log output