Closed Wolfsblvt closed 4 months ago
Fix incoming tomorrow.
Nice, that's fast! Thanks.
I mean there is a workaround, but just not using transparent and hard-coding the background color. But it's not as nice.
@Wolfsblvt it's definitely a bug in the renderer. This issue could theoretically also pop up in the regular segments. I found the issue, just want to look at it again with a fresh pair of eyes (and create a test for it).
Yeah, it was a bit weird. I tried using transparent
inside the actual template for the transient prompt, that one works? For both background and foreground.
And other existing themes use transparent a lot too. So it doesn't always happen with transparent.
@Wolfsblvt it has to do with restoring the previous colors after the override. Instead of resetting the background, we simply print the word transparent.
This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a discussion first, complete the body with all the details necessary to reproduce, and mention this issue as reference.
Code of Conduct
What happened?
I am currently playing around with the transient prompt. Sadly not as easy as with the segments to build something nice and reduced, but I am making progress.
I noticed an interesting bug though. The template I am basing mine off of night-owl, used
"transparent"
as the background color for the transient prompt.No issues if you keep it as is. But if you modify the
"template"
for it in any way and add Color Overrides inside, it breaks.From what I tested, it's very specific to the actual string "transparent" or something. Likely because you use some specific replacement for it to get ARGB, but then the index is messed up?
So, it looks like this when it is broken:
And like this if I set the color to
"black"
instead:You can see how it correctly switched back the font color, but it added
ransparentm
instead of replacing the background color πHere is how I have my transient prompt, to preproduce. Though any scenario should make this break.
And like i said, it works if you set it to
"background": "black"
.Funnily enough, it also works as expected if you had the original background as something invalid. I tried
"background": "blubb"
and it worked.I feel like this might also happen in other template strings, when the background of the element itself is set to transparent? Haven't tested though.
Made an empty command line for the log, just hitting enter in root folder:
Theme
Just a slightly modified version of
night-owl.omp.json
at the moment.What OS are you seeing the problem on?
Windows
Which shell are you using?
powershell
Log output