Closed flcdrg closed 1 month ago
Worked with 21.26.2, 21.28.0, 22.0.0. Appears to break in v23.0.0 (even when I don't specify a custom theme/config)
I note that v23 release notes does mention a breaking change:
git: To use the posh-git module output, you must now set the source property to pwsh in the git segment configuration.
In case you are using the default configuration, you don't need to change anything.
That doesn't sound like it would break the tab completion for adding files, but interestingly when I updated my custom theme to add the source: "pwsh"
to the properties, the tab completion for adding files now starts working.
I'm glad I figured out a way to resolve the problem. Not sure if that is expected, or if I misunderstood the release notes
@flcdrg that's indeed how this is supposed to work now. We initialize posh-git based on that property.
@JanDeDobbeleer So is it supposed to break posh-git git add
if I've imported that before oh-my-posh? That's my case. How to configure this is a little bit confusing actually. Would i need to customize any theme that I use if I want posh-git to work properly? 😕
Alright, to clarify.
$env:POSH_GIT_ENABLED
was removedfunction Set-PoshGitStatus {
$global:GitStatus = Get-GitStatus
$env:POSH_GIT_STRING = Write-GitStatus -Status $global:GitStatus
}
New-Alias -Name 'Set-PoshContext' -Value 'Set-PoshGitStatus' -Scope Global -Force
@krokofant yes, this is also reflected in the docs. Previously it required the use of an environment variable, but as of late, this is a configuration option to avoid having anything else other than oh-my-posh configuration settings.
Code of Conduct
What happened?
Sometime in the last few weeks, posh-git has stopped being able to do tab completion when you have typed
git add
Posh-git (without oh-my-posh) configured still works as expected, but as soon as I enable oh-my-posh it no longer is able to suggest modified files that can be added.
Using 23.6.2 and 23.5.0 on different machines. Both seeing the same issue.
Theme
What OS are you seeing the problem on?
Windows
Which shell are you using?
powershell
Log output