No background color - Githubissues

JanDeDobbeleer / oh-my-posh

The most customisable and low-latency cross platform/shell prompt renderer

https://ohmyposh.dev

MIT License

16.7k stars 2.34k forks source link

No background color #791

Closed PhyX-Meow closed 3 years ago

PhyX-Meow commented 3 years ago

Prerequisites

[x] I have read and understand the CONTRIBUTING guide
[x] I looked for duplicate issues before submitting this one

Description

[Description of the bug or feature]

Environment

Oh My Posh version: 3.162.2 install form scoop
Theme: jandedobbeleer
Operating System: Windows 10.0.21390.1
Shell: PowerShell 7.1.3
Terminal: Windows Terminal 1.8.1521.0

Optional

posh-git version: 1.0.0
git version: 2.32.0.windows.1

Steps to Reproduce

Just open the shell.

Expected behavior:

Background color of the theme is displayed normally.

Actual behavior:

ShrykeWindgrace commented 3 years ago

Other themes are impacted, too.

Ash258 commented 3 years ago

After update to 3.162.2 the color are no longer handled correctly. Reproducible on two ubuntu systems and even windows

Theme: https://github.com/Ash258/Scoop-Ash258/blob/main/support/oh-my-posh/Ash258.json Os1: Ubuntu 21.04 Os2: Ubuntu 20.04 Os3: Wndows 21H1

For both zsh, powershell in Ubuntu

JanDeDobbeleer commented 3 years ago

@Ash258 @ShrykeWindgrace @PhyX-Meow fix is building. I relied on the tests alone, seems like upgrading a dependency ruined the colouring.

Ash258 commented 3 years ago

Can confirm it is OK now

JanDeDobbeleer commented 3 years ago

@Ash258 seems like GitHub is broken though so can't get everything out

JanDeDobbeleer commented 3 years ago

I'm pushing a new version as soon as this is resolved. In the meantime I removed the pwsh module and the faulty homebrew version. Scoop is resolved and that build succeeded, Winget is still impacted.

ShrykeWindgrace commented 3 years ago

@JanDeDobbeleer thanks for the prompt fix!

JanDeDobbeleer commented 3 years ago

Fully fixed in https://github.com/JanDeDobbeleer/oh-my-posh/releases/tag/v3.162.3

github-actions[bot] commented 5 months ago

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a discussion first, complete the body with all the details necessary to reproduce, and mention this issue as reference.