Using Windows Terminal scheme colours

JanDeDobbeleer / oh-my-posh2

A prompt theming engine for Powershell

MIT License

5.18k stars 281 forks source link

Using Windows Terminal scheme colours #253

Closed T-Flet closed 4 years ago

T-Flet commented 4 years ago

ConsoleColor uses a different colour naming convention from the Windows Terminal colour schemes, however, are its enumeration values not supposed to pick up those set by the scheme anyway (e.g. [ConsoleColor]::DarkBlue -> blue and [ConsoleColor]::Blue -> brightBlue)?

(Related Terminal issue https://github.com/microsoft/terminal/issues/5670 and scheme naming issue: https://github.com/microsoft/terminal/issues/2641)

On which side is the issue occurring?

JanDeDobbeleer commented 4 years ago

I would have always supposed this is agnostic on my part as I use the ConsoleColor enumeration. If the Windows terminal defines something on it's own, it's either to PSCore to map it correctly, but simply coming up with your own stuff while the API is cross platform compatible is just asking for issues, no?