JanDeDobbeleer / oh-my-posh2

A prompt theming engine for Powershell
MIT License
5.19k stars 284 forks source link

Incorrect git branch theme colour? #263

Closed wildcardjoker closed 4 years ago

wildcardjoker commented 4 years ago

I'm having an issue with the Agnoster theme on a machine. I'm using Windows Terminal and PowerShell, and the git foreground colour is white instead of black using the Agnoster theme. image

The strange thing is that it only does this on one of my machines. Using the same themes, fonts and other settings I get the expected results (black foreground for git status and leading separator bar triangle). image

SirJson commented 4 years ago

The current color system and how well Themes are staying true to it varies a bit. On top of that the color system is still limited by what Windows defined as Console Colors back then which itself is just a index into your current Terminal theme.

TLDR: I think this is a known issue(?) but needs some refactoring in order to get it right. All dependencies would support such a refactor, someone just needs to properly do it and also maybe talk to the project owner.

JanDeDobbeleer commented 4 years ago

When the project started out, this was the only way to tackle colors on Windows. Nowadays we have additional capabilities, especially when using ANSI, but that requires quite the refactor. The good news is that I actually have a new engine in the works that will use hex codes for maximum customization. But that one's not ready for prime time just yet (might need to alpha track it)

wildcardjoker commented 4 years ago

Thanks, I thought I may have corrupted something somewhere along the line.