fix display issue of vcs icon in powershell

JanDeDobbeleer / oh-my-posh2

A prompt theming engine for Powershell

MIT License

5.19k stars 284 forks source link

fix display issue of vcs icon in powershell #277

Closed dkern closed 4 years ago

dkern commented 4 years ago

Added an invisible unicode space character in front of the vcs/gihub icon to fix display issue in powershell. The issue belongs to the fact, that the icon is wider than monospace characters in the font should be. Using this character fixes the issue.

JanDeDobbeleer commented 4 years ago

Wait, because this issue depends on the font being used, right? You can also adjust the symbol to be both the unicode space and icon, right?

dkern commented 4 years ago

Maybe. I use your fonts. ;)

Yes, the icon is $ThemeSettings.GitSymbols.BranchSymbol and for the space char i've added $ThemeSettings.PromptSymbols.UnicodeSpace.

By the way, i have the same problem with $ThemeSettings.GitSymbols.BranchUntrackedSymbol what is cut on one side too. But i can't fix this, because the icon is only responded by the Get-VcsInfo function, wich i can't edit like this.

JanDeDobbeleer commented 4 years ago

To be honest, this still feels like an issue with the terminal (font spacing) rather than something to fix on oh-my-posh

dkern commented 4 years ago

I have a new installation with powershell and just installed your things like seen here. As there is anything i can test let me know.

JanDeDobbeleer commented 4 years ago

As there is anything i can test

which terminal are you using?

dkern commented 4 years ago

which terminal are you using?

Powershell in Windows Terminal.

dkern commented 4 years ago

Don't answer for two months and then closed without a comment? Nice. 👍

JanDeDobbeleer commented 4 years ago

Hey @dkern , I'm continuing the work for oh-my-posh on V3, meaning the PR's on V2 are no longer valid going forward (unless they address a serious bug).