Closed cbm80 closed 8 years ago
Ja, könnten wir in der Tat. Nur falls jemand, der kein Deutsch kann, jemals auf den PR hier stoßen sollte, wäre für denjenigen halt einfacher uns zu verstehen, wenn wir Englisch schreiben. ;)
'bracket'
Very nice, I wasn't aware of Control.Exception.Lifted
. My version of bracket
was borrowed from here. Should have noted its shortcomings in a comment.
'*status' Message 'disconnect'
IMHO it would be better to keep all the logic related to ZNC in its own package. Therefore I would suggest either catching the exception thrown by disconnect
or checking if the connection is still open, if SimpleIRC
supports that. I will look into this tomorrow.
I couldn't find a good way to add my commit to this PR, so I first merged your PR and then cherry-picked commit 4ca7cb6 with the changes I suggested. Any feedback on my commit?
Btw. if you want to be listed in the contributors graph you probably have to list the commit email address in your settings.
Hallo @JanGe
wir können offenbar deutsch miteinander sprechen.
Ich habe zwei bugs gefixed.
MfG, cbm80