search

JanGorman / Agrume

🍋 A lemony fresh iOS image viewer written in Swift.
MIT License
807 stars 121 forks source link

Basic SwiftUI support #294

Closed hyouuu closed 2 years ago

hyouuu commented 2 years ago

Example shown in readme - only supports single image view without configuration as a starting point. This also doesn't take in the existing presentation animation - please add it on if you now how :p

github-actions[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you.

hyouuu commented 2 years ago

@JanGorman

On Thu, Dec 30, 2021 at 4:25 PM github-actions[bot] < @.***> wrote:

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you.

— Reply to this email directly, view it on GitHub https://github.com/JanGorman/Agrume/pull/294#issuecomment-1003221154, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABGTZ25VEXXEUPQXSCEA2GTUTTZ55ANCNFSM5JCXFCUA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

JanGorman commented 2 years ago

@hyouuu Thanks for the contribution and sorry for the long delay. I'll merge as is and have a think about how to support configurations going forward 🙏

JanGorman commented 2 years ago

I played around a little bit (just an hour) and made some small changes that improve the support somewhat but the different view hierarchies mess it up. I added the example into the sample app that the project ships with. As you commented in the README, PRs welcome 😬