search

JanGorman / Agrume

🍋 A lemony fresh iOS image viewer written in Swift.
MIT License
790 stars 121 forks source link

'ImageAnalysisInteraction' is only available in Mac Catalyst 17.0 or newer #360

Closed willm132 closed 8 months ago

willm132 commented 9 months ago

Screenshot 2023-11-22 at 2 52 15 PM

JanGorman commented 9 months ago

Thanks for reporting. My bad for not considering the mac catalyst support. I pushed a fix and will trigger a new release

On Wed, 22 Nov 2023 at 20:52, Will Mays @.***> wrote:

[image: Screenshot 2023-11-22 at 2 52 15 PM] https://user-images.githubusercontent.com/47162632/285026727-e61e20f6-1f57-4980-89e3-567e43b76ee4.png

— Reply to this email directly, view it on GitHub https://github.com/JanGorman/Agrume/issues/360, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABBXNS3PDVYYYNV2SFQQCLYFZJZPAVCNFSM6AAAAAA7WYGW72VHI2DSMVQWIX3LMV43ASLTON2WKOZSGAYDOMBSGY3TEOI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

willm132 commented 8 months ago

@JanGorman Is there going to be any support for Mac Catalyst in the future? This works great on iOS, and would love for it to work on Mac devices also.

JanGorman commented 8 months ago

@willm132 Actually I never checked on Mac Catalyst and according to the documentation it would work with 17+ so the current !targetEnvironment(macCatalyst) is a bit crude. I'll reopen the issue and work on a fix (alternatively a PR is always welcome 🤗)

JanGorman commented 8 months ago

I published 5.8.9 that enables it when running on Mac Catalyst 17+

willm132 commented 8 months ago

Screenshot 2023-12-15 at 7 43 07 AM

willm132 commented 8 months ago

Great to hear Mac Catalyst support is added!

JanGorman commented 8 months ago

🙈 My bad, pushed a fix for that. Don't release on a Friday…

willm132 commented 8 months ago

Haha, it's working great now thanks!