search

JanGorman / Hippolyte

HTTP Stubbing in Swift
MIT License
111 stars 18 forks source link

304 was incorrectly being redirected #44

Closed richardpineo closed 5 years ago

richardpineo commented 5 years ago

This fixes an issue that I found where 304 was not being handled properly. https://github.com/JanGorman/Hippolyte/issues/43

Sorry if I did the fork / PR wrong here.

codecov[bot] commented 5 years ago

Codecov Report

Merging #44 into master will increase coverage by 0.32%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #44      +/-   ##
==========================================
+ Coverage   90.19%   90.51%   +0.32%     
==========================================
  Files          22       22              
  Lines         561      580      +19     
==========================================
+ Hits          506      525      +19     
  Misses         55       55
Impacted Files Coverage Δ
HippolyteTests/HippolyteTests.swift 100% <100%> (ø) :arrow_up:
Hippolyte/HTTPStubURLProtocol.swift 78.94% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5c3e539...959c161. Read the comment docs.

JanGorman commented 5 years ago

👍 Thank you very much