Closed Volqano closed 3 months ago
So regarding testing and precisely the lack of it. I think we should wait for tests before merging. It's unwise to do it other way because we can possibly push buggy code and later on it might be hard to find the issue. So please wait a bit longer for tests to be fixed. I am close to fixing this issue with testing so the issue should be finished this weekend
Please attach some tutorial for database rebuild, in comment under this PR
Also, when creating PR attach 2 people for review this way you will let them know that their assistance is needed
to rebuild database:
make stop
docker compose down --remove-orphans
sudo rm -rf /var/tmp/heaven_in_mouth_db_data/*
make init
So regarding testing and precisely the lack of it. I think we should wait for tests before merging. It's unwise to do it other way because we can possibly push buggy code and later on it might be hard to find the issue. So please wait a bit longer for tests to be fixed. I am close to fixing this issue with testing so the issue should be finished this weekend
I already fixed the issue with make test
in this #87 PR. So please proceed with adding tests