search

JanKaul / iceberg-rust

Rust implementation of Apache Iceberg with integration for Datafusion
Apache License 2.0
88 stars 13 forks source link

Inconsistent unit test #6

Closed ZENOTME closed 1 year ago

ZENOTME commented 1 year ago

After https://github.com/JanKaul/iceberg-rust/commit/ccbfae6519e7e3cd3f732f00df653b21aaf8aa08, the append api in transcation become pub fn append(mut self, files: Vec<(String, FileMetaData)>).

Some unit test seems not modify accroding it. https://github.com/JanKaul/iceberg-rust/blob/0ed2ff0f7bf6e988bd500f6186a603a6a0e12e3b/iceberg-rust/src/table/files.rs#L152

https://github.com/JanKaul/iceberg-rust/blob/0ed2ff0f7bf6e988bd500f6186a603a6a0e12e3b/iceberg-rust/src/table/transaction/operation.rs#L848

JanKaul commented 1 year ago

Thanks for the heads up. I'm working on a new unit test right now. I will report here once I'm finished. Sorry for pushing this to main, I should have finished this on a separate branch.

JanKaul commented 1 year ago

The unit tests should be fixed now. Again, thanks for the heads up.

ZENOTME commented 1 year ago

Thanks to fix it!