search

JanLunge / pog

A Kmk firmware flashing and configuration tool
https://pog.heaper.de/
MIT License
255 stars 17 forks source link

Feature: Split side configuration #10

Closed Birkemosen closed 2 months ago

Birkemosen commented 2 months ago

Ran into an issue where the split keyboard couldn't reliably use the drivename for detecting the split side.

This adds configuration options under "Matrix" for setting the split configurations.

Add: Keyboard Type selector: Normal | Split (Bluetooth) | Split (Serial) | Split (1 Pin) Add: Split side detection configuration: Config (left / right) | VBUS (with pin) | Label (drivelabel)

pog.json adds the following fields: keyboardType, splitSide, vbusPin

image

NB: Contains the fixes from the other PR.

JanLunge commented 2 months ago

I added some cleanup for the now not needed split value in the keyboardStore, maybe it is better to put the split config into the pins tab so the pin prefix doesnt get to be too confusing (when using the initial keyboard setup, as you would need to go back to the matrix tab after setting the pin prefix)

Birkemosen commented 2 months ago

Makes sense with the cleanup and I will try moving the split config to the pins tab.

Birkemosen commented 2 months ago

I moved the configuration to pins tab.

image VBUS not selected: image VBUS selected: image

JanLunge commented 2 months ago

Perfect this look really nice, on the initial setup it now feels like its in the right place. I just saw you removed the use_pio=True from the split constructor I'm still not sure what would be a good default but on boards not using the standart rx and tx pins this needs to be enabled for it to work on the pi pico rp2040 then there is the uart_flip if the pins are just swapped maybe something i should look at in the future to add as additional toggles. just wanted to point it out here. this worked on my normal boards with matrix wiring i will just test it on another split board before merging.

JanLunge commented 2 months ago

with the pio true added, my split keyboards works so i will leave that in until i find a need to make it configurable. also i forgot to reset the split pins so that is added now as well.

Birkemosen commented 2 months ago

I was unsure about the use_pio, so it s perfect that you have added it. Thanks

JanLunge commented 2 months ago

its now released with version 1.3.1 https://github.com/JanLunge/pog/releases/tag/v1.3.1 Thanks for your contribution