search

JanLunge / pog

A Kmk firmware flashing and configuration tool
https://pog.heaper.de/
MIT License
326 stars 20 forks source link

Fix issue with directPins scanner initialization #9

Closed Birkemosen closed 4 months ago

Birkemosen commented 4 months ago

Noticed a bit of errors setting up a directPins split keyboard.

Fix an issue with initialization of directPins scanner, where it would default to matrix scanner on coordmapHelper. Related issue - when coordMap was available the directPins scanner would not have "features" available.

Fix an issue with the keyMap being filled with "null" values if a layer had unmapped keys. Defaulting to KC.TRNS

Havent had the possibility to test if changes has any impact on matrix boards.

Birkemosen commented 4 months ago

Btw, thanks for a nice tool.

JanLunge commented 4 months ago

oh wow thanks I ran into this issue recently but haven't figured out why it occurs as i had some troubles with the new circuit python 9 release. I will test how it works with my matrix keyboards. also good catch with the KC.TRNS to KC.NO how do you even test for that.

Birkemosen commented 4 months ago

Regarding the check for null, I made the check in the saveConfig. But in hindsight it may not be the best place to do the check ? Btw looking though the code I changed the check to fill in KC.TRNS instead, but maybe there should be KC.NO on layer 0 while all other layers have KC.TRNS. FYI my board is running circuit python 9.0.