search

JanMarvin / openxlsx2

openxlsx2 - read, write and modify xlsx files
https://janmarvin.github.io/openxlsx2/
Other
117 stars 9 forks source link

[wb_dims] without `x` and non sequential rows, incorrect results were returned. fixes #1093 #1094

Closed JanMarvin closed 2 months ago

JanMarvin commented 2 months ago

The output still returns ranges, but that's acceptable. We should be able to catch this and should be able to return A1:A1 as A1.

JanMarvin commented 2 months ago

Maybe this should be included into the check a few lines above. There are a few things going on and obviously something unhandled slipped through and this PR feels a little hackish.

JanMarvin commented 2 months ago

It's better now that everything is in one condition, but I'm still surprised that crossing row 1 is such an issue. It's still hackish and mysteries in my code are not pleasing 😄

JanMarvin commented 2 months ago

Thanks! Rebased on main.