JanMarvin / openxlsx2

openxlsx2 - read, write and modify xlsx files
https://janmarvin.github.io/openxlsx2/
Other
117 stars 9 forks source link

[docs] CRAN warning regarding html #969

Closed JanMarvin closed 6 months ago

JanMarvin commented 6 months ago

https://www.r-project.org/nosvn/R.check/r-devel-linux-x86_64-debian-gcc/openxlsx2-00check.html

checking HTML version of manual ... [8s/17s] NOTE
Found the following HTML validation problems:
convert_date.html:55:1 (convert_date.Rd:23): Warning: trimming empty <dt>
JanMarvin commented 6 months ago

Looks like an R issue

https://github.com/JanMarvin/openxlsx2/blob/95abe2935f67872885a5f9b02eab8cd8b6725faa/R/dates.R#L11

JanMarvin commented 6 months ago

Or probably a roxygen2 issue

olivroy commented 6 months ago

do you know which arguments cause problem


#' @inheritDotParams base::as.Date -arg1 -arg2
JanMarvin commented 6 months ago

Hi @olivroy , no not yet. I’m traveling for the weekend and only have access to my smartphone right now. It looked like some new line was inserted after base::as.Date. We might have to create a custom parameter description for the time being, or patch the html file.

Convert from Excel date, datetime or hms number t…

olivroy commented 6 months ago

looking at the signature, maybe this will work

#' @inheritDotParams base::as.Date.character