search

JanMarvin / readspss

Read the SPSS file formats
https://janmarvin.github.io/readspss/
GNU General Public License v2.0
12 stars 1 forks source link

Iconv on the full vector #4

Closed JanMarvin closed 6 years ago

JanMarvin commented 6 years ago

Currently after a string is read, iconv is called. This already reduced the iconv overhead, still iconv is called for every n. Since R's implementation of iconv is used, it could be run on the full vector after it was read.

JanMarvin commented 6 years ago

pull the full vector and push using SET_VECTOR_ELT just as in read_sav_unknown_n.

JanMarvin commented 6 years ago

Fixed in master