JanRose1 / Neg_Select_Pred

MIT License
0 stars 0 forks source link

Design and Input Clarification #16

Open groyumich opened 1 year ago

groyumich commented 1 year ago

Good job on your project so far! I think what you’re attempting to do here is quite interesting and ambitious, and I’m looking forward to seeing how it develops. I do think that it might be worth going through your design documents and elaborating a bit on the specific details of your project. For one thing, I found navigating your design documents themselves to be slightly confusing. Some documents, such as your DDS, seem to be slightly incomplete. Your SRS was labeled as Neg-Seq-Pred-Design Doc, whereas your file labeled as SRS was mostly about databases that you’re using. I believe that consolidating this information together could help streamline project planning and future peer feedback.

I was also somewhat unclear on a few details of your project. Different statements throughout your readme and design documents make it unclear whether your project involves identifying the fates of lymphocytes or also identifying criteria that informs the fates of those lymphocytes. I thought that you did a great job of considering the computational requirements of your project. However, you I was not able to find an exact list of required inputs anywhere; I would consider deciding upon and including this information, or emphasizing and consolidating it more if it is present. However, I think that you have several very interesting ideas here and I am curious to see how they will develop.

JanRose1 commented 1 year ago

Yeah I definitely need to sit down and clean up my files and add more information/eliminate that which isn't relevant. Research had me reconsidering the fate of my project multiple times and I've had to readjust accordingly multiple times now. I'd say it's about the best thing I can do at the moment before I continue coding extensively. Now I have a more clear idea of what I'd like to pursue and I'd like the next iteration of my design docs to reflect that.