search

JanStevens / angular-growl-2

growl-like notifications for angularJS projects
MIT License
285 stars 97 forks source link

Some convenient tweaks I found useful working with Java backend #41

Closed madhead closed 10 years ago

JanStevens commented 10 years ago

Hello thanks for your contribution.

It's a great addition to have a general way to add growl notifications when you don't really know the severity. I'm just thinking of another name for the method then notify, maybe general?

growl.general(...)

We already have growl.error growl.warning etc, I want to keep it a bit consistent. If you can think of another name then notify please change it, I prefer general over notify, maybe growl.severity. After my holiday I'll merge it with the final name but thank you for your contribution!

madhead commented 10 years ago

Hello, Jan!

Thanks for applying this. I've amended last commit according your comments. Looks like Github is smart enough to recognize this and update PR ))