JanStevens / angular-growl-2

growl-like notifications for angularJS projects
MIT License
285 stars 97 forks source link

Added support to Zurb Foundation #44

Open Jacq opened 10 years ago

Jacq commented 10 years ago

Just a quick solution to add the css classes to use Zurb Foundation alert messages. To enable it I have added a "foundation" attribute to the growl directive and split the css for the icons in two different files with two different grunt build tasks.

JanStevens commented 10 years ago

Hmm I like the idea for zurb foundation support but the implementation is a bit over the top. I think we can support both frameworks by adding the bootstrap and zurb classes.

class="alert alert-success alert-box success"

Or we create two separate builds, zurb or bootstrap (I dont think any one really needs to support both frameworks at the same time). We would need a little more auto build magic (so we dont need an if / else in the code)

dfilipovic39 commented 9 years ago

How about a possibility to override classes and icons by defining override either via provider or two way binded attribute on directive? That only leaves template override that could be done by example in documentation?

JanStevens commented 9 years ago

Overwriting classes and icons is a good idea, a bit more configuration and logical defaults are always nice. Would you mind creating a new PR with configurable classes and icons? Thanks!

dfilipovic39 commented 9 years ago

are builds done automatically? i dont have grunt installed and please grant me permissions to the repository

sgarbesi commented 9 years ago

Should just allow a custom template file, give developers the freedom to make their own templates.