search

JanStevens / angular-growl-2

growl-like notifications for angularJS projects
MIT License
285 stars 97 forks source link

onopen and onclose #48

Closed pabloleone closed 9 years ago

pabloleone commented 9 years ago

I'm using onopen and onclose hooks, but after looking at the code I realise that hte version 0.7.0 downloaded using bower is not the last version. Those hooks are missing.

Could you tag a new version with the current code to download using bower?

Thanks,

JanStevens commented 9 years ago

You can also change your bower config to pull master instead of 0.7.0

On Thursday, October 16, 2014, Pablo Ezequiel Leone Signetti < notifications@github.com> wrote:

I'm using onopen and onclose hooks, but after looking at the code I realise that hte version 0.7.0 downloaded using bower is not the last version. Those hooks are missing.

Could you tag a new version with the current code to download using bower?

Thanks,

— Reply to this email directly or view it on GitHub https://github.com/JanStevens/angular-growl-2/issues/48.

~Jan Stevens

JanStevens commented 9 years ago

New version includes onopen and onclose

maeishoj commented 9 years ago

well doesn't look like.. or i can't seem to find out... how do i assign a custom function onClose event?

royerboat commented 9 years ago

@maeishoj Take a look at the docs for info on hooking into onclose and onopen. http://janstevens.github.io/angular-growl-2/#config-message-callbacks

maeishoj commented 9 years ago

@royerboat thanks a lot! I'm not sure how I didn't see that documentation page before! :/ odd.. I did however figure out where to place them just before you responded by looking at the code ;)

I had assumed the onclose callback to be passed to the html tag, but makes sense to have it where it is. :)

Thanks a lot for your help!