weird template expression in growlDirective.js

JanStevens / angular-growl-2

growl-like notifications for angularJS projects

MIT License

285 stars 97 forks source link

Closed nebulaszlonemethi closed 10 years ago

nebulaszlonemethi commented 10 years ago

~line 11: ng-show="!message.enableTitle"

attribute "enableTitle" is never set/used/documented so that is undefined - the expression is of course will always be evaluated to be true
the expression is semantically bad, correct way would be: ng-show="message.enableTitle"

JanStevens commented 10 years ago

I'll look into it tonight, seems wierd

nebulaszlonemethi commented 10 years ago

thx, would be fine to be able to control the title, even the text of it;)

nebulaszlonemethi commented 10 years ago

Well done! Recently this one is the best growl module for Angular by my opinion