wrong index initialization in destroyAllMessages function

[Siggen]

In version v0.7.3, the destroyAllMessages function is defined like this :

this.destroyAllMessages = function (referenceId) {
  var messages = this.getAllMessages(referenceId), i = messages.length;
  for (i - 1; i >= 0; i--) {
    messages[i].destroy();
  }
  if (this.directives[referenceId]) {
    this.directives[referenceId].messages = [];
  }
};

On the first loop, notice the i - 1 statement which does nothing. Calling this method on an empty messages array will iterate one time and will raise an exception because messages[0] returns undefined.

I propose the following version :

this.destroyAllMessages = function (referenceId) {
  var messages = this.getAllMessages(referenceId);
  for (var i = messages.length - 1; i >= 0; i--) {
    messages[i].destroy();
  }
  if (this.directives[referenceId]) {
    this.directives[referenceId].messages = [];
  }
};

[royerboat]

I submitted a pull request to fix this. Hopefully it gets picked up.

[Siggen]

Thanks a lot !

[JanStevens]

Nice catch, I'll look at the MR :+1:

[Siggen]

That was quick, thanks :-)