search

JanStevens / angular-growl-2

growl-like notifications for angularJS projects
MIT License
285 stars 97 forks source link

Feature request: Return the configuration object on config methods #72

Closed diosney closed 9 years ago

diosney commented 9 years ago

Right now I'm setting the global configuration as this:

  growlProvider.globalTimeToLive(5000);
  growlProvider.globalDisableIcons(true);

which reads awfully.

When doing:

  growlProvider
            .globalTimeToLive(5000)
            .globalDisableIcons(true);

It is triggering the following error:

growlProvider.globalTimeToLive(...) is undefined

so it appears it is not retuning the growlProvider instance.

Can this be added so we can chain config setters?

JanStevens commented 9 years ago

Sure feel free to add a PR!

diosney commented 9 years ago

I'm on that right now :)

One question, though, should I have to build the library before submitting the PR?

diosney commented 9 years ago

Any updates on this?