Replace $timeout by $interval to allow tests with protractor

JanStevens / angular-growl-2

growl-like notifications for angularJS projects

MIT License

285 stars 97 forks source link

Replace $timeout by $interval to allow tests with protractor #81

Closed gregwym closed 8 years ago

gregwym commented 9 years ago

Protractor wait for $timeout to finish before start testing. Growl ttl should use $interval instead, to enable protractor to validate the notification message.

https://github.com/marcorinck/angular-growl/issues/43 angular/protractor#169

k3v3n commented 9 years ago

Any plan to fix this ?

silbermm commented 9 years ago

:+1:

area commented 9 years ago

This seems like a pretty obvious thing to do. Is there a reason you're hesitant, @JanStevens?

EDIT: I somehow missed the pending pull request, and you're waiting on tests to be included.