search

JanStevens / angular-growl-2

growl-like notifications for angularJS projects
MIT License
285 stars 97 forks source link

Error in IE8 closing messages #96

Closed sistemanick closed 8 years ago

sistemanick commented 9 years ago

Getting "TypeError: Object doesn't support this property or method" errors when closing messages.

I fixed it by replacing line 409 with the following: var messages = this.getAllMessages(message.referenceId), index = -1;

for (var i in messages) index = (messages[i] == message) ? i : index;

flippinjoe commented 9 years ago

Please submit a PR for this fix

sistemanick commented 9 years ago

For some reason I can't create a new branch. Emailed Github, awaiting reply.

flippinjoe commented 9 years ago

You do not have push permissions to this repo. Please fork the repo, and make your changes on your own account, then submit a PR from your fork

sistemanick commented 9 years ago

Well that's what I first tried, but every time I tried to "fork" (using the top-right button), it forks the old "marcorinck/angular-growl" project. Sorry completely new to this thing :)

sistemanick commented 9 years ago

Managed to create pull request... please check