STUSB4500 configuration support, OLED init, PID tune and compiler warnings

tuna-f1sh commented 4 years ago

So there are quite a lot of changes in this, more than you would probably like for a merge but I took the point in README about firmware debugging/development to heart! Quite a few system and configuration tweaks I found to work well during bring-up (some decisive perhaps) so worth a good review and test. The broad points are:

OLED initialisation revised based on datasheet 4.4.4 seems to resolve the black/white noise I had on some start ups but they also appeared to be cold start dependant so not 100% sure on this yet. I read in the Otter-Iron repo others have had problems with this display so it might just be hardware. Doesn't break anything though so can't not help.
STUSB4500 PD profile setup and detection of profile configured. I've added info on the detected PD configured at boot and prevented MOSFET driving if no PD is advertised. I separated this source so you can merge it into the non-Pro if you want.
Added some type casting causing some compiler warnings, moved CDC buffers because of now default -fno-common error.
I reversed the button direction - should probably take this out since it's my preference but thought arrow up should increase temperature and vice versa.
Made the MAX_DUTY a constant define like MIN_DUTY for clamp and added a work wduty in it's place.

In all, it's a nice compact soldering iron and working well I think (already done some small jobs with it). My main iron is a Metcal (which I swear by) but this is almost comparable. Would be to add a sleep mode but can't think of a nice way of achieving this with being connected to a stand/adding a sensor to handle. Heat up time is so quick, I just unplug at the moment.

jeanthom commented 4 years ago

Ideally we should eliminate .d. o and .lst files from the Git repository. Otherwise it gets cluttered and file diffs are unreadable.

tuna-f1sh commented 4 years ago

Agreed, I was very tempted but didn't want to make even more changes. The 104 files changes makes me sad though! I'm going to add a .gitignore and update this.

Jana-Marie commented 4 years ago

You are amazing, thank you very much! :)

Jana-Marie / Otter-Iron-PRO

STUSB4500 configuration support, OLED init, PID tune and compiler warnings #7