Shortfall does not work when I(1-px) and/or I(1-py) is missing

JanaJarecki / cognitivemodels

Cognitivemodels is an open-source R library to create, fit, test, and compare computational cognitive models based on machine-learning principles.

25 stars 4 forks source link

Shortfall does not work when I(1-px) and/or I(1-py) is missing #38

Closed FlorianSeitz closed 4 years ago

FlorianSeitz commented 4 years ago

https://github.com/JanaJarecki/cognitivemodels/blob/e4b7196f9e5aaf3f8e89e771f39a0be6a07e242f/tests/testthat/test_shortfall.R#L132

As compared to cpt, shortfall only works if all probabilities are specified (i.e., also I(1-px) and I(1-py) must be specified). You might consider making this more flexible?