Closed bentaculum closed 8 months ago
Just noticed, the tests for the CTCMatcher are a bit minimalistic in general, it wouldn't hurt to add a test for the CTCMatcher that uses a non-equal GT and prediction.
@DragaDoncila @bentaculum I added the suggested tests. I also removed the unusued TrackingGraph.get_nodes_in_frame()
function in favor of the implemented defaultdict approach. I believe the failing tests are due to the pandas dependency issue and not the actual tests (since they run locally) but I will have to fix that and merge to be sure.
Awesome, thanks :)
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
f4398e8
) 91.64% compared to head (96a57cd
) 91.63%.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Proposed Change
Fixes #138.
Types of Changes
What types of changes does your code introduce? Put an x in the boxes that apply.
Which topics does your change affect? Put an x in the boxes that apply.
TrackingGraph
,run_metrics
,cli
, etc.)Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.